-
Notifications
You must be signed in to change notification settings - Fork 248
Recent change broke my app =( #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 0094b57.
@caseywebdev Have you tried #118 before opening this issue? #115 removes the obsolete (badly documented) syntax and enables the new one. We should not use the old syntax anymore, even if it seems to be broader supported at the moment. Nevertheless #115 tries to translate to the old syntax, so apps for old browsers don't break. This is #115' + #118's support:
Untranslated new properties:
Obsolete properties that are now inaccessible:
As long as you don't use @visionmedia At the moment we have two syntaxes to accomplish an (almost) same result. When the new syntax gets standardised should we switch to the new one (which still partially translates to support older browsers) and deprecate the old one? |
I wasn't aware of the new syntax, but I see what you mean. Changing display box
box-align center
box-pack center to display flex
justify-content center
align-items center Is now yielding the correct results. I'm +1 for #118, but I fear for everyone else who is going to run into this suddenly. |
Cool man! Thanks! :D It's up to @visionmedia, what we do. |
I dont know I dont have time to keep track of all these things haha, whatever actually works is a +1 from me |
haha well yeah that's why we should get it reasonably right the first time |
This reverts commit 0094b57.
These are still necessary! Latest Safari, Chrome, and Firefox still need prefixes...